fix: Apply batched updates to resize observer callback #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 27 27
Lines 642 644 +2
Branches 175 172 -3
=======================================
+ Hits 637 639 +2
Misses 5 5 ☔ View full report in Codecov by Sentry. |
Member
|
Has this been somehow tested? |
jperals
reviewed
Dec 6, 2024
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { unstable_batchedUpdates } from 'react-dom'; |
Member
There was a problem hiding this comment.
Note that react-dom is a dev dependency —is this okay? Consumers of this package might not get it installed
Member
Author
There was a problem hiding this comment.
We already use it in this package: https://github.com/search?q=repo%3Acloudscape-design%2Fcomponent-toolkit%20unstable_batchedUpdates&type=code
Member
Author
Only manually. This API changes internal react things, you cannot write a test on this |
jperals
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Optimization for React, if there will be multiple state changes inside
onObserve, they will be batched into a single re-renderBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.