Skip to content

fix: Apply batched updates to resize observer callback #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
just-boris merged 1 commit into from
Dec 6, 2024
Merged

fix: Apply batched updates to resize observer callback #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/internal/container-queries/use-resize-observer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0

import { unstable_batchedUpdates } from 'react-dom';
Copy link
Member

@jperals jperals Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that react-dom is a dev dependency —is this okay? Consumers of this package might not get it installed

Copy link
Member Author

@just-boris just-boris Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already use it in this package: https://github.com/search?q=repo%3Acloudscape-design%2Fcomponent-toolkit%20unstable_batchedUpdates&type=code

import { ResizeObserver, ResizeObserverEntry } from '@juggle/resize-observer';
import { useEffect, useLayoutEffect } from 'react';
import { ContainerQueryEntry, ElementReference } from './interfaces';
Expand Down Expand Up @@ -56,7 +57,9 @@ export function useResizeObserver(elementRef: ElementReference, onObserve: (entr
const observer = new ResizeObserver(entries => {
// Prevent observe notifications on already unmounted component.
if (connected) {
stableOnObserve(convertResizeObserverEntry(entries[0]));
unstable_batchedUpdates(() => {
stableOnObserve(convertResizeObserverEntry(entries[0]));
});
}
});
observer.observe(element);
Expand Down
Loading