Skip to content

Conversation

@teodoranemes
Copy link
Contributor

@teodoranemes teodoranemes commented Aug 5, 2025

Issue #, if available:

Description of changes:

Moved validate-props method to component-toolkit package to make it also accessible for other packages.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.40%. Comparing base (dfbb81d) to head (f142c57).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   99.39%   99.40%           
=======================================
  Files          33       34    +1     
  Lines         830      840   +10     
  Branches      234      237    +3     
=======================================
+ Hits          825      835   +10     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0

import { validateProps } from '../validate-props';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the components package, the tests were importing from the lib directory, but the build failed here with that approach.

gethinwebster
gethinwebster previously approved these changes Aug 6, 2025
@teodoranemes teodoranemes marked this pull request as ready for review August 6, 2025 11:22
@teodoranemes teodoranemes requested a review from a team as a code owner August 6, 2025 11:22
@teodoranemes teodoranemes requested review from georgylobko and removed request for a team and georgylobko August 6, 2025 11:22
@teodoranemes teodoranemes added this pull request to the merge queue Aug 6, 2025
@teodoranemes teodoranemes removed this pull request from the merge queue due to a manual request Aug 6, 2025
@teodoranemes teodoranemes added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 072bd91 Aug 6, 2025
36 checks passed
@teodoranemes teodoranemes deleted the move-validate-props branch August 6, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants