-
Notifications
You must be signed in to change notification settings - Fork 7
fix: Move validate-props method to component-toolkit package #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 99.39% 99.40%
=======================================
Files 33 34 +1
Lines 830 840 +10
Branches 234 237 +3
=======================================
+ Hits 825 835 +10
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { validateProps } from '../validate-props'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the components package, the tests were importing from the lib directory, but the build failed here with that approach.
Issue #, if available:
Description of changes:
Moved validate-props method to component-toolkit package to make it also accessible for other packages.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.