feat: Pass package source name in component usage metric #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 36 36
Lines 893 893
Branches 248 235 -13
=======================================
Hits 887 887
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jperals
requested review from
ClaudioGSDB and
just-boris
and removed request for
a team
pan-kot
reviewed
Sep 10, 2025
| // "used" – individual component used | ||
| action: 'loaded' | 'used'; | ||
| configuration?: ComponentConfiguration; | ||
| packageSource?: string; |
Member
There was a problem hiding this comment.
Why is it called packageSource instead of sourcePackage or just package?
Member
Author
There was a problem hiding this comment.
Based on the existing context.packageSource, but I don't have a strong preference.
Could also be packageName for consistency with componentName.
Let's call it package for simplicity?
just-boris
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Pass package name along with component metrics so that we can distinguish from components from different packages that have the same name (motivation: Pie Chart from Components vs Pie Chart from Chart Components).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.