Skip to content

Conversation

@just-boris
Copy link
Member

Description

Another fix to unblock: cloudscape-design/component-toolkit#117

Related links, issue #, if available: n/a

How has this been tested?

Built with the new version of the toolkit, it compiles now

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris force-pushed the remove-flashbar-metrics branch from 3b8aed1 to cf7fe96 Compare January 30, 2025 12:32
@just-boris just-boris changed the title Remove flashbar metrics chore: Update metrics reporting Jan 30, 2025
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (9a18a8c) to head (eee765a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3236   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         790      790           
  Lines       22299    22299           
  Branches     7249     7249           
=======================================
  Hits        21508    21508           
  Misses        784      784           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris force-pushed the remove-flashbar-metrics branch from cf7fe96 to eee765a Compare January 30, 2025 12:41
@just-boris just-boris marked this pull request as ready for review January 30, 2025 12:57
@just-boris just-boris requested a review from a team as a code owner January 30, 2025 12:57
@just-boris just-boris requested review from YueyingLu and removed request for a team January 30, 2025 12:57
@just-boris just-boris added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit ae3d6be Jan 30, 2025
38 checks passed
@just-boris just-boris deleted the remove-flashbar-metrics branch January 30, 2025 13:17
dpitcock pushed a commit that referenced this pull request Jan 30, 2025
georgylobko pushed a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants