Skip to content

chore: Update metrics reporting #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
just-boris merged 1 commit into from
Jan 30, 2025
Merged

chore: Update metrics reporting #3236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/alert/__tests__/runtime-content.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ describe('asynchronous rendering', () => {
const message = `"${method}" called after component unmounted`;
expect(consoleWarnSpy).toBeCalledWith('[AwsUi]', '[alert-content-replacer]', message);
expect(sendPanoramaMetricSpy).toBeCalledWith({
eventName: 'awsui-runtime-api-warning',
eventContext: 'awsui-runtime-api-warning',
eventDetail: {
component: 'alert-content-replacer',
version: expect.any(String),
Expand Down Expand Up @@ -374,7 +374,7 @@ test('can only register a single provider', () => {
)
);
expect(sendPanoramaMetricSpy).toHaveBeenCalledWith({
eventName: 'awsui-runtime-api-warning',
eventContext: 'awsui-runtime-api-warning',
eventDetail: {
component: 'alert-flash-content',
version: expect.any(String),
Expand Down
2 changes: 1 addition & 1 deletion src/flashbar/__tests__/runtime-content.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ describe('asynchronous rendering', () => {
const message = `"${method}" called after component unmounted`;
expect(consoleWarnSpy).toBeCalledWith('[AwsUi]', '[flash-content-replacer]', message);
expect(sendPanoramaMetricSpy).toBeCalledWith({
eventName: 'awsui-runtime-api-warning',
eventContext: 'awsui-runtime-api-warning',
eventDetail: {
component: 'flash-content-replacer',
version: expect.any(String),
Expand Down
2 changes: 1 addition & 1 deletion src/internal/plugins/__tests__/api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ describe('usage metrics', () => {
expect(sendPanoramaMetricSpy).toHaveBeenCalledTimes(1);
expect(sendPanoramaMetricSpy).toHaveBeenCalledWith(
expect.objectContaining({
eventName: 'awsui-runtime-api-loaded',
eventContext: 'awsui-runtime-api-loaded',
})
);

Expand Down
4 changes: 2 additions & 2 deletions src/internal/plugins/controllers/__tests__/drawers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe('console warnings', () => {
expect.stringMatching(/multiple app layout instances detected/)
);
expect(sendPanoramaMetricSpy).toHaveBeenCalledWith({
eventName: 'awsui-runtime-api-warning',
eventContext: 'awsui-runtime-api-warning',
eventDetail: {
component: 'app-layout-drawers',
version: expect.any(String),
Expand All @@ -136,7 +136,7 @@ describe('console warnings', () => {
expect.stringMatching(/drawer with id "drawerA" is already registered/)
);
expect(sendPanoramaMetricSpy).toHaveBeenCalledWith({
eventName: 'awsui-runtime-api-warning',
eventContext: 'awsui-runtime-api-warning',
eventDetail: {
component: 'app-layout-drawers',
version: expect.any(String),
Expand Down
4 changes: 2 additions & 2 deletions src/internal/plugins/helpers/metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ import { PACKAGE_VERSION } from '../../environment';
import { metrics } from '../../metrics';

export function reportRuntimeApiLoadMetric() {
metrics.sendPanoramaMetric({ eventName: 'awsui-runtime-api-loaded', eventDetail: { version: PACKAGE_VERSION } });
metrics.sendPanoramaMetric({ eventContext: 'awsui-runtime-api-loaded', eventDetail: { version: PACKAGE_VERSION } });
}

export function reportRuntimeApiWarning(component: string, message: string) {
console.warn('[AwsUi]', `[${component}]`, message);
metrics.sendPanoramaMetric({
eventName: 'awsui-runtime-api-warning',
eventContext: 'awsui-runtime-api-warning',
eventDetail: { version: PACKAGE_VERSION, component, message },
});
}
Loading