Skip to content

chore: Use <mark> element for filtering highlights#3249

Merged
avinashbot merged 2 commits intomainfrom
use-html-mark
Feb 5, 2025
Merged

chore: Use <mark> element for filtering highlights#3249
avinashbot merged 2 commits intomainfrom
use-html-mark

Conversation

@avinashbot
Copy link
Member

@avinashbot avinashbot commented Feb 4, 2025

Description

<mark> indicates a portion of the document's content which is likely to be relevant to the user's current activity. This might be used, for example, to indicate the words that matched a search operation. (MDN)

Now you know!

Related links, issue #, if available: AWSUI-60213

How has this been tested?

It's an HTML element change - ideally, it should slip past our tests and any tests for those that use the components.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (a07a737) to head (02e9dc6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3249    +/-   ##
========================================
  Coverage   96.44%   96.44%            
========================================
  Files         791      791            
  Lines       22563    22563            
  Branches     7381     7788   +407     
========================================
  Hits        21760    21760            
  Misses        796      796            
  Partials        7        7            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avinashbot avinashbot marked this pull request as ready for review February 5, 2025 10:24
@avinashbot avinashbot requested a review from a team as a code owner February 5, 2025 10:24
@avinashbot avinashbot requested review from jperals and removed request for a team February 5, 2025 10:24
@avinashbot avinashbot requested a review from jperals February 5, 2025 11:49
@avinashbot avinashbot enabled auto-merge February 5, 2025 11:59
@avinashbot avinashbot added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 1ade36a Feb 5, 2025
38 checks passed
@avinashbot avinashbot deleted the use-html-mark branch February 5, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants