Skip to content

chore: Use <mark> element for filtering highlights #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avinashbot merged 2 commits into from
Feb 5, 2025
Merged

chore: Use <mark> element for filtering highlights #3249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c243788
chore: Use <mark> element for filtering highlights
avinashbot Feb 4, 2025
02e9dc6
Update a unit test to check for MARK.
avinashbot Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/internal/components/option/highlight-match.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@ interface HighlightMatchProps {
highlightText?: string;
}

const Highlight = ({ str }: HighlightMatchProps) =>
str ? <span className={styles['filtering-match-highlight']}>{str}</span> : null;
function Highlight({ str }: HighlightMatchProps) {
return str ? <mark className={styles['filtering-match-highlight']}>{str}</mark> : null;
}

export default function HighlightMatch({ str, highlightText }: HighlightMatchProps) {
if (!str || !highlightText) {
Expand Down
4 changes: 3 additions & 1 deletion src/property-filter/__tests__/property-filter-autosuggest.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ describe('Property filter autosuggest', () => {
expect(wrapper.findDropdown().findOption(1)!.getElement()).toHaveTextContent('abc');
});
test('is used for highlighting', () => {
expect(wrapper.findDropdown().findHighlightedMatches()[0].getElement()).toHaveTextContent('abc');
const highlightMatch = wrapper.findDropdown().findHighlightedMatches()[0].getElement();
expect(highlightMatch.tagName).toBe('MARK');
expect(highlightMatch).toHaveTextContent('abc');
});
test('is not used for the enteredText- option', () => {
expect(wrapper.findEnteredTextOption()!.getElement()).toHaveTextContent('123');
Expand Down
Loading