Skip to content

fix: Add I18nProvider support for code editor theme filtering input#3265

Merged
avinashbot merged 1 commit intomainfrom
code-editor-filter-labels
Feb 7, 2025
Merged

fix: Add I18nProvider support for code editor theme filtering input#3265
avinashbot merged 1 commit intomainfrom
code-editor-filter-labels

Conversation

@avinashbot
Copy link
Member

@avinashbot avinashbot commented Feb 7, 2025

Description

What it says on the tin. We missed those strings earlier, adding support for them now.

Related links, issue #, if available: AWSUI-60202

How has this been tested?

Updated unit tests.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot marked this pull request as ready for review February 7, 2025 15:02
@avinashbot avinashbot requested a review from a team as a code owner February 7, 2025 15:02
@avinashbot avinashbot requested review from gethinwebster and removed request for a team February 7, 2025 15:02
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (35a2b2a) to head (d5c51fa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3265    +/-   ##
========================================
  Coverage   96.44%   96.44%            
========================================
  Files         791      791            
  Lines       22567    22567            
  Branches     7384     7800   +416     
========================================
  Hits        21764    21764            
+ Misses        796      750    -46     
- Partials        7       53    +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avinashbot avinashbot added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 95c1247 Feb 7, 2025
40 checks passed
@avinashbot avinashbot deleted the code-editor-filter-labels branch February 7, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants