-
Notifications
You must be signed in to change notification settings - Fork 208
chore: Exposes internal dependencies for chart components #3333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3333 +/- ##
==========================================
- Coverage 96.49% 96.49% -0.01%
==========================================
Files 807 806 -1
Lines 23066 23079 +13
Branches 7908 7564 -344
==========================================
+ Hits 22258 22270 +12
- Misses 754 802 +48
+ Partials 54 7 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d16413c to
b46a812
Compare
b46a812 to
22b4ec0
Compare
22b4ec0 to
1271512
Compare
c8f1968 to
628134b
Compare
628134b to
ff25059
Compare
ff25059 to
add95be
Compare
25d26ab to
23394fd
Compare
f66631f to
79858c2
Compare
26fdec1 to
f76a5de
Compare
src/expandable-section/internal.tsx
Outdated
| id={triggerControlId} | ||
| descriptionId={descriptionId} | ||
| className={clsx(styles.header, styles[`header-${baseVariant}`])} | ||
| className={clsx(styles.header, styles[`header-${baseVariant}`], 'awsui-screenreader-text')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The awsui-screenreader-text class name is used to locate the part of the expandable section to get extracted for screenreader announcement. It it used in the series-detail-text util. The same approach is to be reused in the chart-components, where we can't use the hashed internal class name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we solve this alternatively by extracting a selector with this class to a scss file to be added to the internal/do-not-use directory?
This is an approach we are already using, and we would avoid customers using this class name directly.
854533a to
a63602c
Compare
Description
Fixes small issues and exposes internal components to be consumed by new chart components (cloudscape-design/chart-components#2).
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.