Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Mar 6, 2025

Description

Fixes small issues and exposes internal components to be consumed by new chart components (cloudscape-design/chart-components#2).

How has this been tested?

  • New unit tests
  • Screenshot tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.49%. Comparing base (dddd3f5) to head (5858cdb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/popover/use-popover-position.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3333      +/-   ##
==========================================
- Coverage   96.49%   96.49%   -0.01%     
==========================================
  Files         807      806       -1     
  Lines       23066    23079      +13     
  Branches     7908     7564     -344     
==========================================
+ Hits        22258    22270      +12     
- Misses        754      802      +48     
+ Partials       54        7      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot force-pushed the charts-design-tokens branch 3 times, most recently from d16413c to b46a812 Compare March 7, 2025 08:40
@pan-kot pan-kot force-pushed the charts-design-tokens branch from b46a812 to 22b4ec0 Compare March 19, 2025 12:26
@pan-kot pan-kot force-pushed the charts-design-tokens branch from 22b4ec0 to 1271512 Compare March 20, 2025 11:02
@pan-kot pan-kot force-pushed the charts-design-tokens branch 3 times, most recently from c8f1968 to 628134b Compare April 1, 2025 05:51
@pan-kot pan-kot force-pushed the charts-design-tokens branch from 628134b to ff25059 Compare April 1, 2025 06:24
@pan-kot pan-kot force-pushed the charts-design-tokens branch from ff25059 to add95be Compare April 3, 2025 09:37
@pan-kot pan-kot force-pushed the charts-design-tokens branch 7 times, most recently from 25d26ab to 23394fd Compare April 14, 2025 06:25
@pan-kot pan-kot changed the title chore: Exposes more design tokens to be used by charts chore: Exposes internal dependencies for chart components Apr 22, 2025
@pan-kot pan-kot force-pushed the charts-design-tokens branch 2 times, most recently from f66631f to 79858c2 Compare April 22, 2025 16:13
@pan-kot pan-kot force-pushed the charts-design-tokens branch 2 times, most recently from 26fdec1 to f76a5de Compare April 22, 2025 16:28
id={triggerControlId}
descriptionId={descriptionId}
className={clsx(styles.header, styles[`header-${baseVariant}`])}
className={clsx(styles.header, styles[`header-${baseVariant}`], 'awsui-screenreader-text')}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The awsui-screenreader-text class name is used to locate the part of the expandable section to get extracted for screenreader announcement. It it used in the series-detail-text util. The same approach is to be reused in the chart-components, where we can't use the hashed internal class name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we solve this alternatively by extracting a selector with this class to a scss file to be added to the internal/do-not-use directory?

This is an approach we are already using, and we would avoid customers using this class name directly.

jperals
jperals previously approved these changes Apr 24, 2025
@pan-kot pan-kot added this pull request to the merge queue Apr 25, 2025
Merged via the queue into main with commit 5347d78 Apr 25, 2025
38 checks passed
@pan-kot pan-kot deleted the charts-design-tokens branch April 25, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants