chore: Add hideButtonsOnDrag and clickDragThreshold property to InternalDragHandle #3545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalDragHandle Both options are used to allow more flexibility. Use cases: - hideButtonsOnDrag: When using the UAP handles on board-items they're activated once clicked the handle. While dragging is active, ths buttons should be shown. This helps to distinctive in between the pointer and step interaction. - clickDragThreshold: to make the threshold configurable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3545 +/- ##
==========================================
- Coverage 96.55% 96.54% -0.01%
==========================================
Files 804 804
Lines 23438 23439 +1
Branches 8174 8169 -5
==========================================
Hits 22630 22630
- Misses 754 755 +1
Partials 54 54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johannes-weber
requested review from
avinashbot and
gethinwebster
and removed request for
a team and
gethinwebster
avinashbot
approved these changes
Jun 2, 2025
at-susie
pushed a commit
that referenced
this pull request
Oct 10, 2025
…nalDragHandle (#3545) Co-authored-by: Johannes Weber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both options are used to allow more flexibility. Use cases:
hideButtonsOnDrag: When using the UAP handles on board-items they're activated once clicked the handle. While dragging is active, the buttons, if visible, should be hidden. This helps to distinguish in between the pointer and step interaction modes.clickDragThreshold: A "click" happens when a "pointerdown" is followed by a "pointerup" with no "pointermove" between the two.However, it would be a poor usability experience if a "click" isn't registered because, while pressing my mouse, I moved it by just one pixel, making it a "drag" instead. So we allow the pointer to move by
clickDragThresholdto count as click instead of a move.Related links, issue #, if available: cloudscape-design/board-components#356 (comment)
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.