-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add UAP directional controls and tooltips to drag/resize handles #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add UAP directional controls and tooltips to drag/resize handles #356
Conversation
83c1a11 to
36dfb4a
Compare
6048e6b to
f482393
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 94.37% 94.63% +0.25%
==========================================
Files 68 68
Lines 3128 3278 +150
Branches 674 694 +20
==========================================
+ Hits 2952 3102 +150
Misses 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4f4c495 to
08f03c2
Compare
08f03c2 to
f566d4c
Compare
This commit enhances the accessibility of board items by adding UAP (Universally Accessible Post-click/tap actions) controls and tooltips to drag and resize handles. UAPs allows drag/resize movements to be operated by a single pointer without dragging. As part of that change: Show blue border around items when they are active: Before this change, the "active" borders have been shown only when interacting with keyboard. Now they will be shown on pointer interactions (drag or resize) as well.
f566d4c to
4d1d1a5
Compare
|
@johannes-weber , I noticed that active state does not always show the outline. Screen.Recording.2025-05-27.at.17.51.11.mov |
|
@johannes-weber , is it expected that the "Drag or select to move" tooltip is shown on hover interaction, but not shown on focus interaction? |
|
@johannes-weber , I noticed that sometimes upon closing toggling the drag handle, the UAP buttons re-appear for a split second. Screen.Recording.2025-05-27.at.17.55.40.mov |
…nstead of click to mimic actual behaviour
That's caused by the board currently not tolerating any
Yes, that's expected.
That's been an issue with the CSS animation. It got fixed in cloudscape-design/components#3543 |
…ze handles (#356)" (#360) Co-authored-by: Johannes Weber <[email protected]>
Description
This PR enhances the accessibility of board items by adding UAP (Universally Accessible Post-click/tap actions) controls and tooltips to drag and resize handles. UAPs allows drag/resize movements to be operated by a single pointer without dragging.
Screen recording of the new functionality:
Screen.Recording.2025-05-21.at.17.24.10.mov
Changes:
i18nStrings.useInternalDragHandleInteractionStatefrom the components package.Visual Changes:
PR follow ups:
ItemContainerComponentlocated insrc/internal/item-container/index.tsxwith a focus on improving it's readability and extracting pure functions.Related links, issue #, if available:
AWSUI-60240sPYUAQa9vqDXHow has this been tested?
7381967744.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.