refactor: apply ES2019 optional catch binding and array methods #4036
Conversation
- Remove unused catch parameters in 3 files (optional catch binding) - Replace array reduce patterns with flatMap in visible-content - Replace Set iteration with Array.from in make-scaled-series
TrevorBurnham
requested review from
gethinwebster
and removed request for
a team
| // Consumers in the past have not always been able to support not specifiying the value so we keep and ignore | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| } catch (e) { | ||
| } catch { |
There was a problem hiding this comment.
Not merge blocking but I would like to hear your thoughts – how do you debug such code?
I have got a few cases where I investigated an issue, I traced it down to such anonymous catch block, but there was no clue how I ended up there. Is there any debug trick to know the currently being thrown error?
There was a problem hiding this comment.
That's a good point. In that case I think you'd want to add an error to the catch temporarily for debugging purposes. It does seem like a gap that dev tools don't provide a stack trace in that scenario. 😞
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4036 +/- ##
==========================================
- Coverage 96.99% 96.99% -0.01%
==========================================
Files 861 861
Lines 25209 25207 -2
Branches 9093 9093
==========================================
- Hits 24451 24449 -2
Misses 752 752
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ab08f66
2 participants
Description
Follow-up for #3986
This PR applies some minor code optimizations that take advantage of ES2019 features. These changes reduce measured bundle size by 833 bytes.
How has this been tested?
All unit tests are passing. No changes in behavior are expected.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.