lib: Use browser context menu on shift#22920
Merged
mvollmer merged 1 commit intocockpit-project:mainfrom Feb 26, 2026
Merged
Conversation
With Firefox explicitly preventing pages from interrupting the browser context menu while holding shift we should adopt that to all browsers. This is a quality of life thing where users will now be able to access inspect or any other extension-related context menu items that was otherwise difficult for them to do. Fixes: cockpit-project#22919 See-also: https://developer.mozilla.org/en-US/docs/Web/API/Element/contextmenu_event Signed-off-by: Freya Gustavsson <freya@venefilyn.se>
cockpituous
reviewed
Feb 24, 2026
Comment on lines
+32
to
+34
| if (event.shiftKey) { | ||
| setVisible(false); | ||
| return; |
Contributor
There was a problem hiding this comment.
These 3 added lines are not executed by any test. Details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Firefox explicitly preventing pages from interrupting the browser
context menu while holding shift we should adopt that to all browsers.
This is a quality of life thing where users will now be able to access
inspect or any other extension-related context menu items that was
otherwise difficult for them to do.
Fixes: #22919
See-also: https://developer.mozilla.org/en-US/docs/Web/API/Element/contextmenu_event
Signed-off-by: Freya Gustavsson freya@venefilyn.se
Use browser's context menu when holding
ShiftTo help with accessibility and user-specific items in your browser context menu we now follow the behavior seen in Firefox. Holding
Shiftkey while right-clicking will now skip our own context menu and instead use the default behavior of your browser. Note that while Cockpit Files uses the Cockpit context menu it did not get the update before this release, but is scheduled for next release.