Skip to content

lib: Use browser context menu on shift #22920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvollmer merged 1 commit into from
Feb 26, 2026
Merged

lib: Use browser context menu on shift #22920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/lib/cockpit-components-context-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ export const ContextMenu = ({ parentId, children } : {

React.useEffect(() => {
const _handleContextMenu = (event: MouseEvent) => {
/* In Firefox they explicitly prevent us from interrupting when holding shift while
* right-clicking for context. Lets make it default for all browsers so they can inspect et. al.
*/
if (event.shiftKey) {
setVisible(false);
return;
Comment on lines +32 to +34
Copy link
Contributor

@cockpituous cockpituous Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 added lines are not executed by any test. Details

}
event.preventDefault();

setVisible(true);
Expand Down