changefeedccl: fix unwatched column families memory monitoring bug #154802
+99
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andyyang890
force-pushed
the
20251003-fix-alloc-leak
branch
from
fb86bc0 to
3804925
Compare
andyyang890
changed the title
andyyang890
added
backport-24.1.x
andyyang890
force-pushed
the
20251003-fix-alloc-leak
branch
3 times, most recently
from
445e667 to
fc8482b
Compare
aerfrei
approved these changes
Oct 6, 2025
| } | ||
|
|
||
| // Update watched column again to verify the feed is still progressing. | ||
| // If the memory allocations leaked, this assertion would time out. |
There was a problem hiding this comment.
Is there a way to get this to fail with a clearer symptom than a timeout (at least for enterprise feeds)? This is my first time looking at the memory monitor, but my sense was that since this would set a low PerChangefeedMemLimit, that the memory monitors should fail the feed once the limit is passed. But when I tried to check that on the status of the feed in this test, I saw that it was still running.
There was a problem hiding this comment.
If the allocations leaked, the memory monitor wouldn't fail; instead, the changefeed would get stuck, which is why the assertion would time out. I added some more explanatory comments to the test.
This patch fixes a bug where the memory monitor wouldn't reclaim the memory allocated to events corresponding to unwatched column families for a changefeed that targets only a subset of a table's families. Release note (bug fix): A bug where a changefeed targeting only a subset of a table's column families could become stuck has been fixed.
andyyang890
force-pushed
the
20251003-fix-alloc-leak
branch
from
fc8482b to
a14e13a
Compare
asg0451
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where the memory monitor wouldn't reclaim the
memory allocated to events corresponding to unwatched column families
for a changefeed that targets only a subset of a table's families.
Fixes #154776
Release note (bug fix): A bug where a changefeed targeting only a subset
of a table's column families could become stuck has been fixed.