Skip to content

Conversation

ajstorm
Copy link
Collaborator

@ajstorm ajstorm commented Oct 6, 2025

The action's OIDC token exchange is failing, likely because the GitHub
app isn't configured to accept OIDC tokens from this workflow. By
explicitly providing the built-in GITHUB_TOKEN, we bypass the OIDC
exchange entirely.

The built-in token has sufficient permissions for PR analysis and
commenting, which is all this workflow needs.

🤖 Generated with Claude Code

The action's OIDC token exchange is failing, likely because the GitHub
app isn't configured to accept OIDC tokens from this workflow. By
explicitly providing the built-in GITHUB_TOKEN, we bypass the OIDC
exchange entirely.

The built-in token has sufficient permissions for PR analysis and
commenting, which is all this workflow needs.

Release note: None
Epic: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajstorm ajstorm requested a review from rickystewart October 6, 2025 13:17
@ajstorm ajstorm marked this pull request as ready for review October 6, 2025 13:17
@ajstorm ajstorm requested a review from a team as a code owner October 6, 2025 13:17
When using pull_request_target, the workflow runs in the context of the
base branch. By default, checkout merges with the target branch, which
could result in the LLM reporting on things that don't appear to
actually exist in the PR.

Explicitly set ref to the PR head SHA to analyze the actual PR code.

Release note: None
Epic: None
@ajstorm
Copy link
Collaborator Author

ajstorm commented Oct 6, 2025

bors r=rickystewart

@craig
Copy link
Contributor

craig bot commented Oct 6, 2025

@craig craig bot merged commit 1f663ab into cockroachdb:master Oct 6, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants