roachprod: fix parse int for grow #154858
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the number of nodes to grow a cluster by was limited to the max of a signed byte. This change increases the limit to a word. Epic: None Release note: None
herkolategan
requested review from
srosenberg and
golgeek
and removed request for
a team
|
This change is |
DarrylWong
approved these changes
Oct 6, 2025
|
TFTR! bors r=DarrylWong |
herkolategan
commented
Oct 6, 2025
| @@ -166,7 +166,7 @@ be fairly distributed across the zones of the cluster). | |||
| `, | |||
| Args: cobra.ExactArgs(2), | |||
| Run: Wrap(func(cmd *cobra.Command, args []string) error { | |||
| count, err := strconv.ParseInt(args[1], 10, 8) | |||
There was a problem hiding this comment.
ran into this while growing a cluster by more than 100 nodes.
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the number of nodes to grow a cluster by was limited to the max of a signed byte. This change increases the limit to a word.
Epic: None
Release note: None