Skip to content

sql/export: skip columns with Bit(0) type in parquet test #160093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craig merged 1 commit into from
Dec 26, 2025
Merged

sql/export: skip columns with Bit(0) type in parquet test #160093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pkg/sql/export/exportparquet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,22 @@ func TestRandomParquetExports(t *testing.T) {
require.NoError(t, err)

for _, col := range cols {
// Skip tables with BIT(0) columns (or arrays of BIT(0)).
// The testutils parquet decoder cannot decode these as
// into the expected empty bit array and decodes the as
// nil. Ignore these to avoid these flakes.
colTyp := col.Typ
if colTyp.Family() == types.ArrayFamily {
colTyp = colTyp.ArrayContents()
}
if colTyp.Family() == types.BitFamily && colTyp.Width() == 0 {
// We skip these because of the aforementioned
// decoder issue.
t.Logf("skipping table '%s' because it has BIT(0) column '%s' (type: %s)",
tableName, col.Name, colTyp.String())
return fmt.Errorf("table has BIT(0) column")
}

// TODO(#104278): don't call this function to check if a type is supported.
// We should explicitly use the ones supported by util/parquet).
_, err := parquet.NewSchema([]string{"test"}, []*types.T{col.Typ})
Expand Down
Loading