-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sql/export: skip columns with Bit(0) type in parquet test #160093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Two random seeds that were helpful in verifying this off of master: |
We were seeing failures on this randomized test when these columns were generated. The testutils parquet decoder can't handle this type (added in cockroachdb#132944) so these fail, but it doesn't represent a real issue. This fix skips these the randomly generated test cases that include this column type. Fixes: cockroachdb#154011 Epic: none Release note: None
65cea5b to
5c8981c
Compare
|
bors r=KeithCh,asg0451 |
|
blathers backport all |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. unexpected status code: 404 Not Found Backport to branch all failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
blathers backport-all |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 5c8981c to blathers/backport-release-24.3-160093: POST https://api.github.com/repos/aerfrei/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-24.3 failed. See errors above. error creating merge commit from 5c8981c to blathers/backport-release-25.2-160093: POST https://api.github.com/repos/aerfrei/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-25.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
We were seeing failures on this randomized test when these columns were generated. The testutils parquet decoder can't handle this type (added in #132944) so these fail, but it doesn't represent a real issue.
This fix skips these the randomly generated test cases that include this column type.
Fixes: #154011
Epic: none
Release note: None