Skip to content

Conversation

@aerfrei
Copy link
Contributor

@aerfrei aerfrei commented Dec 23, 2025

We were seeing failures on this randomized test when these columns were generated. The testutils parquet decoder can't handle this type (added in #132944) so these fail, but it doesn't represent a real issue.

This fix skips these the randomly generated test cases that include this column type.

Fixes: #154011
Epic: none
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@aerfrei
Copy link
Contributor Author

aerfrei commented Dec 23, 2025

Two random seeds that were helpful in verifying this off of master:
1802813790182486420 is a test failing with Bit(0)
4107181287183127133 is a seed with a column with non length 0 bit array that is not skipped.

@aerfrei aerfrei marked this pull request as ready for review December 24, 2025 00:06
@aerfrei aerfrei requested a review from a team as a code owner December 24, 2025 00:06
@aerfrei aerfrei requested review from KeithCh and log-head and removed request for a team and log-head December 24, 2025 00:06
We were seeing failures on this randomized test when these
columns were generated. The testutils parquet decoder can't
handle this type (added in cockroachdb#132944) so these fail, but it
doesn't represent a real issue.

This fix skips these the randomly generated test cases that
include this column type.

Fixes: cockroachdb#154011
Epic: none

Release note: None
@aerfrei aerfrei requested a review from asg0451 December 26, 2025 14:45
@aerfrei
Copy link
Contributor Author

aerfrei commented Dec 26, 2025

bors r=KeithCh,asg0451

@craig
Copy link
Contributor

craig bot commented Dec 26, 2025

@craig craig bot merged commit 7302175 into cockroachdb:master Dec 26, 2025
25 checks passed
@aerfrei
Copy link
Contributor Author

aerfrei commented Dec 26, 2025

blathers backport all

@blathers-crl
Copy link

blathers-crl bot commented Dec 26, 2025

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


unexpected status code: 404 Not Found

Backport to branch all failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@aerfrei
Copy link
Contributor Author

aerfrei commented Dec 26, 2025

blathers backport-all

@blathers-crl
Copy link

blathers-crl bot commented Dec 26, 2025

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 5c8981c to blathers/backport-release-24.3-160093: POST https://api.github.com/repos/aerfrei/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-24.3 failed. See errors above.


error creating merge commit from 5c8981c to blathers/backport-release-25.2-160093: POST https://api.github.com/repos/aerfrei/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-25.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql/importer: TestRandomParquetExports failed

4 participants