workload: treat rename destination conflicts as potential errors #160652
+30
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename operations (e.g., sequences, tables) check for name conflicts at snapshot time but execute later, allowing concurrent transactions to change the destination state. This can cause expected errors (e.g., DuplicateRelation) to not occur, leading to false workload failures. The workload now treats such cases as potential errors instead of hard failures. Example: ``` TX1: Checks seq_w18_32 exists → TRUE TX1: Expects error on renaming to seq_w18_32 TX2: Renames seq_w18_32 away → commits TX1: Rename unexpectedly succeeds - workload fails: error was expected but not raised ``` Closes cockroachdb#160465 Release note: none Epic: none
Member
|
This change is |
spilchen
requested review from
a team,
herkolategan and
shailendra-patel
and removed request for
a team
fqazi
approved these changes
Jan 8, 2026
Collaborator
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
Thank you for tracking this one down @spilchen . I'll get a follow up issue open, since this is a leased descriptor limitation. I think we can get a retry to happen in this scenario, but it's not the more urgent thing, since its not the most realistic scenario.
@fqazi made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan and @shailendra-patel).
fqazi
reviewed
Jan 8, 2026
Collaborator
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
Opened: #160697
@fqazi made 1 comment.
Reviewable status:
Contributor
Author
|
TFTR! bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename operations (e.g., sequences, tables) check for name conflicts at snapshot time but execute later, allowing concurrent transactions to change the destination state. This can cause expected errors (e.g., DuplicateRelation) to not occur, leading to false workload failures.
The workload now treats such cases as potential errors instead of hard failures.
Example:
Closes #160465
Release note: none
Epic: none