Skip to content

workload: treat rename destination conflicts as potential errors #160652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craig merged 1 commit into from
Jan 8, 2026
+30 −33
Merged

workload: treat rename destination conflicts as potential errors #160652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 30 additions & 33 deletions pkg/workload/schemachange/operation_generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2251,21 +2251,21 @@ func (og *operationGenerator) renameColumn(ctx context.Context, tx pgx.Tx) (*opS
if err != nil {
return nil, err
}
destColumnExists, err := og.columnExistsOnTable(ctx, tx, tableName, destColumnName)
if err != nil {
return nil, err
}

stmt := makeOpStmt(OpStmtDDL)
stmt.expectedExecErrors.addAll(codesWithConditions{
{pgcode.UndefinedColumn, !srcColumnExists},
{pgcode.DuplicateColumn, destColumnExists && srcColumnName != destColumnName},
})
// The column may be referenced in a view or trigger, which can lead to a
// dependency error. This is particularly hard to detect in cases where renaming
// a column that is part of a hash-sharded primary key triggers a cascading rename
// of the crdb_internal shard column, which might be used indirectly by other objects.
stmt.potentialExecErrors.add(pgcode.DependentObjectsStillExist)
stmt.potentialExecErrors.addAll(codesWithConditions{
// The column may be referenced in a view or trigger, which can lead to a
// dependency error. This is particularly hard to detect in cases where renaming
// a column that is part of a hash-sharded primary key triggers a cascading rename
// of the crdb_internal shard column, which might be used indirectly by other objects.
{code: pgcode.DependentObjectsStillExist, condition: true},
// Duplicate name errors are potential because destination name conflicts
// can change after checking.
{code: pgcode.DuplicateColumn, condition: srcColumnName != destColumnName},
})

stmt.sql = fmt.Sprintf(`ALTER TABLE %s RENAME COLUMN %s TO %s`,
tableName.String(), srcColumnName.String(), destColumnName.String())
Expand Down Expand Up @@ -2307,15 +2307,15 @@ func (og *operationGenerator) renameIndex(ctx context.Context, tx pgx.Tx) (*opSt
if err != nil {
return nil, err
}
destIndexExists, err := og.indexExists(ctx, tx, tableName, destIndexName)
if err != nil {
return nil, err
}

stmt := makeOpStmt(OpStmtDDL)
stmt.expectedExecErrors.addAll(codesWithConditions{
{code: pgcode.UndefinedObject, condition: !srcIndexExists},
{code: pgcode.DuplicateRelation, condition: destIndexExists && srcIndexName != destIndexName},
})
// Duplicate name errors are potential because destination name conflicts can
// change after checking.
stmt.potentialExecErrors.addAll(codesWithConditions{
{code: pgcode.DuplicateRelation, condition: srcIndexName != destIndexName},
})

stmt.sql = fmt.Sprintf(`ALTER INDEX %s@"%s" RENAME TO "%s"`,
Expand Down Expand Up @@ -2350,19 +2350,18 @@ func (og *operationGenerator) renameSequence(ctx context.Context, tx pgx.Tx) (*o
return nil, err
}

destSequenceExists, err := og.sequenceExists(ctx, tx, destSequenceName)
if err != nil {
return nil, err
}

srcEqualsDest := srcSequenceName.String() == destSequenceName.String()
stmt := makeOpStmt(OpStmtDDL)
stmt.expectedExecErrors.addAll(codesWithConditions{
{code: pgcode.UndefinedTable, condition: !srcSequenceExists},
{code: pgcode.UndefinedSchema, condition: !destSchemaExists},
{code: pgcode.DuplicateRelation, condition: !srcEqualsDest && destSequenceExists},
{code: pgcode.InvalidName, condition: srcSequenceName.Schema() != destSequenceName.Schema()},
})
// Duplicate name errors are potential because destination name conflicts can
// change after checking.
stmt.potentialExecErrors.addAll(codesWithConditions{
{code: pgcode.DuplicateRelation, condition: !srcEqualsDest},
})

stmt.sql = fmt.Sprintf(`ALTER SEQUENCE %s RENAME TO %s`, srcSequenceName, destSequenceName)
return stmt, nil
Expand Down Expand Up @@ -2400,11 +2399,6 @@ func (og *operationGenerator) renameTable(ctx context.Context, tx pgx.Tx) (*opSt
return nil, err
}

destTableExists, err := og.tableExists(ctx, tx, destTableName)
if err != nil {
return nil, err
}

srcTableHasDependencies, err := og.tableHasDependencies(ctx, tx, srcTableName, false, /* includeFKs */
false /* skipSelfRef */)
if err != nil {
Expand All @@ -2416,10 +2410,14 @@ func (og *operationGenerator) renameTable(ctx context.Context, tx pgx.Tx) (*opSt
stmt.expectedExecErrors.addAll(codesWithConditions{
{code: pgcode.UndefinedTable, condition: !srcTableExists},
{code: pgcode.UndefinedSchema, condition: !destSchemaExists},
{code: pgcode.DuplicateRelation, condition: !srcEqualsDest && destTableExists},
{code: pgcode.DependentObjectsStillExist, condition: srcTableHasDependencies},
{code: pgcode.InvalidName, condition: srcTableName.Schema() != destTableName.Schema()},
})
// Duplicate name errors are potential because destination name conflicts can
// change after checking.
stmt.potentialExecErrors.addAll(codesWithConditions{
{code: pgcode.DuplicateRelation, condition: !srcEqualsDest},
})

stmt.sql = fmt.Sprintf(`ALTER TABLE %s RENAME TO %s`, srcTableName, destTableName)
return stmt, nil
Expand Down Expand Up @@ -2451,11 +2449,6 @@ func (og *operationGenerator) renameView(ctx context.Context, tx pgx.Tx) (*opStm
return nil, err
}

destViewExists, err := og.viewExists(ctx, tx, destViewName)
if err != nil {
return nil, err
}

srcTableHasDependencies, err := og.tableHasDependencies(ctx, tx, srcViewName, true, /* includeFKs */
false /* skipSelfRef */)
if err != nil {
Expand All @@ -2467,10 +2460,14 @@ func (og *operationGenerator) renameView(ctx context.Context, tx pgx.Tx) (*opStm
stmt.expectedExecErrors.addAll(codesWithConditions{
{code: pgcode.UndefinedTable, condition: !srcViewExists},
{code: pgcode.UndefinedSchema, condition: !destSchemaExists},
{code: pgcode.DuplicateRelation, condition: !srcEqualsDest && destViewExists},
{code: pgcode.DependentObjectsStillExist, condition: srcTableHasDependencies},
{code: pgcode.InvalidName, condition: srcViewName.Schema() != destViewName.Schema()},
})
// Duplicate name errors are potential because destination name conflicts can
// change after checking.
stmt.potentialExecErrors.addAll(codesWithConditions{
{code: pgcode.DuplicateRelation, condition: !srcEqualsDest},
})

stmt.sql = fmt.Sprintf(`ALTER VIEW %s RENAME TO %s`, srcViewName, destViewName)
return stmt, nil
Expand Down
Loading