Add Ruby 3.4 compatibility gems to Gemfile #21244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed:
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explicit dependencies for
csv,logger,base64, andbigdecimalgems to support Ruby 3.4+.Background
Starting in Ruby 3.4.0, several gems that were previously included in the standard library were removed from the default gems bundle.
This causes build failures when running Jekyll on Ruby 3.4+ with errors like:
cannot load such file -- csv (LoadError)cannot load such file -- logger (LoadError)cannot load such file -- base64 (LoadError)cannot load such file -- bigdecimal (LoadError)I upgraded to Ruby 3.4 locally given the likelihood that it would improve build times, and so it was necessary to add these gems to my Gemfile explicitly. There is no harm in adding these to the Gemfile in the repo—they are still bundled with 3.2 by default. Explicitly adding them to the Gemfile doesn't cause any issues - Bundler will just use the versions that are already available.
However, the benefit is that we can freely upgrade Ruby on team members machines, as well as our preview and production deployment environments.
Changes
Explicitly adds these gems to the Gemfile:
csv- required by Jekylllogger- required by Jekyllbase64- required by safe_yaml (Jekyll dependency)bigdecimal- required by Liquid (Jekyll dependency)Compatibility
These changes are fully backward compatible with Ruby 3.2.x:
No changes required for existing workflows or production builds running Ruby 3.2.1.
Testing
make standardworks with Ruby 3.4.7