Added scopes support to the configuration#161
Open
philocalyst wants to merge 7 commits intocococonscious:mainfrom
Open
Added scopes support to the configuration#161philocalyst wants to merge 7 commits intocococonscious:mainfrom
philocalyst wants to merge 7 commits intocococonscious:mainfrom
Conversation
Closed
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
cococonscious
requested changes
Dec 10, 2025
Owner
cococonscious
left a comment
cococonscious
left a comment
There was a problem hiding this comment.
Looks good, there's just a small feature I want with this, as commented.
By the way, what would you think about also adding a configuration for enforcing the preconfigured scopes?
src/lib/config.rs
Outdated
| #[derive(Clone, Debug, Deserialize, PartialEq, Eq)] | ||
| pub struct CommitScope { | ||
| pub name: String, | ||
| pub description: Option<String>, |
Owner
There was a problem hiding this comment.
I think a description is a good idea, it would also help with differentiating preconfigured and detected types at a glance, but to do that the description would need to be visible in the multiselect prompt, perhaps display it something like " - "?
Owner
|
@philocalyst I think you've accidentally overridden your scope configuration changes with the gix ones |
Author
|
Yeah this is a bit of a mess... Give me a day or tow
▰▰▰▰▰
Miles Wirht 🙃
… From: Finley Thomalla ***@***.***>
Sent: 12 December 2025 04:27
To: cococonscious/koji ***@***.***>
Cc: Miles Wirht ***@***.***>, Mention ***@***.***>
Subject: Re: [cococonscious/koji] Added scopes support to the configuration (PR #161)
cococonscious left a comment (cococonscious/koji#161)
@philocalyst I think you've accidentally overridden your scope configuration changes with the gix ones
--
Reply to this email directly or view it on GitHub:
#161 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think in the future this should be the default approach as it's more declarative, and works cleanly on repositories without conventinoal commit... commit history