Skip to content

Conversation

@lemorage
Copy link
Contributor

@lemorage lemorage commented Jun 7, 2025

Relates to #586. Should have been part of it.

This PR uses PyO3 NumPy bindings to handle NumPy array vector conversions.

@lemorage lemorage changed the title feat: handle numpy array vector in Python conversion feat: handle NumPy array vector in Python conversion Jun 7, 2025
@badmonster0
Copy link
Member

In #594 we added a new testutil validate_full_roundtrip() that can execute a full roundtrip of conversion (involving both Python and Rust conversion logic). Can we add new tests using this for vector types in test_convert.py? Thanks!

@lemorage lemorage force-pushed the handle-numpy-vector branch from e696279 to 0f4e843 Compare June 9, 2025 03:04
@lemorage lemorage force-pushed the handle-numpy-vector branch from bfc3df9 to 87b91b2 Compare June 11, 2025 14:10
@lemorage lemorage force-pushed the handle-numpy-vector branch from 87b91b2 to 98026b5 Compare June 11, 2025 15:07
@badmonster0
Copy link
Member

Really neat. Thanks a lot! Merging.

@badmonster0 badmonster0 merged commit e4dcb9a into cocoindex-io:main Jun 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants