fix(ci): add numpy to dependencies and pass typing checks #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badmonster0
approved these changes
Jun 30, 2025
Member
badmonster0
left a comment
badmonster0
left a comment
There was a problem hiding this comment.
Thanks for making this quick fix!
In NumPy release 1.23.2, Python 3.11 support was added. See https://github.com/numpy/numpy/releases/tag/v1.23.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI failure.
numpydep is missing, after makingsentence-transformersoptional since Make sentence_transformers an optional dependency #674. Becausesentence-transformerspulled in numpy as one of its dependencies, our code used numpy implicitly.mypytype checks failed, cuz imports won't be found, aftersentence-transformersis optional.