Skip to content

fix(ci): add numpy to dependencies and pass typing checks #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

fix(ci): add numpy to dependencies and pass typing checks #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ba39ce
fix(ci): add numpy to dependencies and pass typing checks
lemorage Jun 30, 2025
d76a7ab
fix: relax numpy version requirement
lemorage Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dependencies = [
"rich>=14.0.0",
"python-dotenv>=1.1.0",
"watchfiles>=1.1.0",
"numpy>=1.23.2",
]
license = "Apache-2.0"
urls = { Homepage = "https://cocoindex.io/" }
Expand Down
15 changes: 6 additions & 9 deletions python/cocoindex/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,17 @@
"""All builtin functions."""

from typing import Annotated, Any, TYPE_CHECKING, Literal
import numpy as np
from numpy.typing import NDArray
import dataclasses
from typing import Annotated, Any, Literal

from .typing import Float32, Vector, TypeAttr
from . import op, llm
import numpy as np
from numpy.typing import NDArray

# Libraries that are heavy to import. Lazily import them later.
if TYPE_CHECKING:
import sentence_transformers
from . import llm, op
from .typing import TypeAttr, Vector

# Check if sentence_transformers is available
try:
import sentence_transformers
import sentence_transformers # type: ignore

_SENTENCE_TRANSFORMERS_AVAILABLE = True
except ImportError:
Expand Down