Feat: Adds-Changes to Lesson14 .Java files for Nile Jackson #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydmays
requested changes
Oct 27, 2024
| Product product = products.get(productId); | ||
| if (product == null) { | ||
| throw new ProductNotFoundException("Product with ID 1 not found"); |
There was a problem hiding this comment.
What if the productId isn't 1? The message should change.
| Order order = orders.get(orderId); | ||
| if (order == null) throw new OrderNotFoundException("Order with ID 1 not found"); |
There was a problem hiding this comment.
Same message as above but for orderId
| public void cancelOrder(String orderId) throws OrderNotFoundException { | ||
| Order order = orders.get(orderId); | ||
| try { | ||
| if (order == null) throw new OrderNotFoundException("No Such order exists"); |
There was a problem hiding this comment.
This is not in the requirements for this assignment.
|
All requested changes have been corrected @anthonydmays , thank you |
anthonydmays
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my e-commerce exception handling assignment for Lesson14.