-
Notifications
You must be signed in to change notification settings - Fork 25
Feat: Adds-Changes to Lesson14 .Java files for Nile Jackson #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b786150
Feat: Adds-Changes to Lesson14 .Java files for Nile Jackson
nilejack 7016d66
Feat: fix
nilejack 91b2e1e
Feat fix to "Order"
nilejack b1d9238
fix
nilejack db47616
fix
nilejack a7bb9c7
spotlessApply/fix
nilejack bff48e2
fix
nilejack 1ade369
fix/Changed values
nilejack 891b4e4
fix
nilejack e50e851
Feat: syntax fix
nilejack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,19 +17,29 @@ public void addProduct(String productId, String name) { | |
products.put(productId, new Product(productId, name)); | ||
} | ||
|
||
public String placeOrder(String productId, int quantity) { | ||
public String placeOrder(String productId, int quantity) throws ProductNotFoundException { | ||
Product product = products.get(productId); | ||
if (product == null) { | ||
throw new ProductNotFoundException("Product with ID 1 not found"); | ||
} | ||
String orderId = UUID.randomUUID().toString(); | ||
orders.put(orderId, new Order(orderId, product, quantity)); | ||
return orderId; | ||
} | ||
|
||
public void cancelOrder(String orderId) { | ||
public void cancelOrder(String orderId) throws OrderNotFoundException { | ||
Order order = orders.get(orderId); | ||
try { | ||
if (order == null) throw new OrderNotFoundException("No Such order exists"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not in the requirements for this assignment. |
||
} catch (OrderNotFoundException e) { | ||
System.out.println(" order does not exist"); | ||
} | ||
orders.remove(orderId); | ||
} | ||
|
||
public String checkOrderStatus(String orderId) { | ||
public String checkOrderStatus(String orderId) throws OrderNotFoundException { | ||
Order order = orders.get(orderId); | ||
if (order == null) throw new OrderNotFoundException("Order with ID 1 not found"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same message as above but for |
||
return "Order ID: " | ||
+ orderId | ||
+ ", Product: " | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the
productId
isn't 1? The message should change.