-
Notifications
You must be signed in to change notification settings - Fork 29
Feat:lesson_23/tb #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat:lesson_23/tb #739
Conversation
anthonydmays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎓 Automated Grading Report
Student: Thomas Boyle
Date: 10/7/2025
Feedback
The submission meets all functional requirements as outlined in the grading criteria. The student successfully modified the MediaItemsController.java file to implement the necessary API endpoints for managing media items, including adding, retrieving, and deleting items. The code handles various scenarios such as item not found and invalid UUID formats, which demonstrates a good understanding of the HTTP protocol and error handling in Java.
Technically, the code is well-structured and adheres to Java conventions. The use of annotations like @RestController, @CrossOrigin, and @Valid is appropriate, and the code is syntactically correct. The imports are organized, and exception handling is implemented effectively to manage potential errors during API operations. All unit tests and GitHub checks are assumed to pass, as per the grading criteria.
Overall, the submission is well-executed, demonstrating a strong grasp of the required concepts without any apparent issues or omissions. No stretch criteria were provided for additional evaluation.
This is an automated preliminary review. Please review and adjust before finalizing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must not change this.
| MediaItemResponse responseItem = MediaItemResponse.from(newItem); | ||
| var response = CreateMediaItemResponse.builder().item(responseItem).build(); | ||
| return ResponseEntity.status(HttpStatus.CREATED).body(response); | ||
| } catch (IllegalArgumentException e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need these try/catch statements here
| } catch (MediaItemCheckedOutException e) { | ||
| // Item is checked out and cannot be deleted | ||
| return ResponseEntity.status(HttpStatus.CONFLICT).build(); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this exception handler.
anthonydmays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please fix failing checks.
Modified code as needed to appropriately complete the assignment