-
Notifications
You must be signed in to change notification settings - Fork 29
Feat:lesson_23/tb #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tboyle252-sudo
wants to merge
1
commit into
code-differently:main
Choose a base branch
from
tboyle252-sudo:feat/lesson_23/tb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat:lesson_23/tb #739
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 2 additions & 1 deletion
3
lesson_23/api/java/api_app/src/main/java/com/codedifferently/lesson23/Lesson23.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,28 @@ | ||
| package com.codedifferently.lesson23.web; | ||
|
|
||
| import com.codedifferently.lesson23.library.Librarian; | ||
| import com.codedifferently.lesson23.library.Library; | ||
| import com.codedifferently.lesson23.library.MediaItem; | ||
| import com.codedifferently.lesson23.library.search.SearchCriteria; | ||
| import java.io.IOException; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
| import java.util.UUID; | ||
|
|
||
| import org.springframework.http.HttpStatus; | ||
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.web.bind.annotation.CrossOrigin; | ||
| import org.springframework.web.bind.annotation.DeleteMapping; | ||
| import org.springframework.web.bind.annotation.GetMapping; | ||
| import org.springframework.web.bind.annotation.PathVariable; | ||
| import org.springframework.web.bind.annotation.PostMapping; | ||
| import org.springframework.web.bind.annotation.RequestBody; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| import com.codedifferently.lesson23.library.Librarian; | ||
| import com.codedifferently.lesson23.library.Library; | ||
| import com.codedifferently.lesson23.library.MediaItem; | ||
| import com.codedifferently.lesson23.library.exceptions.MediaItemCheckedOutException; | ||
| import com.codedifferently.lesson23.library.search.SearchCriteria; | ||
|
|
||
| import jakarta.validation.Valid; | ||
|
|
||
| @RestController | ||
| @CrossOrigin | ||
| public class MediaItemsController { | ||
|
|
@@ -31,4 +42,56 @@ public ResponseEntity<GetMediaItemsResponse> getItems() { | |
| var response = GetMediaItemsResponse.builder().items(responseItems).build(); | ||
| return ResponseEntity.ok(response); | ||
| } | ||
|
|
||
| @PostMapping("/items") | ||
| public ResponseEntity<CreateMediaItemResponse> createItem( | ||
| @Valid @RequestBody CreateMediaItemRequest request) { | ||
| try { | ||
| MediaItem newItem = MediaItemRequest.asMediaItem(request.getItem()); | ||
| library.addMediaItem(newItem, librarian); | ||
|
|
||
| MediaItemResponse responseItem = MediaItemResponse.from(newItem); | ||
| var response = CreateMediaItemResponse.builder().item(responseItem).build(); | ||
| return ResponseEntity.status(HttpStatus.CREATED).body(response); | ||
| } catch (IllegalArgumentException e) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't need these try/catch statements here |
||
| return ResponseEntity.badRequest().build(); | ||
| } catch (Exception e) { | ||
| return ResponseEntity.internalServerError().build(); | ||
| } | ||
| } | ||
|
|
||
| @GetMapping("/items/{id}") | ||
| public ResponseEntity<MediaItemResponse> getItem(@PathVariable UUID id) { | ||
| if (!library.hasMediaItem(id)) { | ||
| return ResponseEntity.notFound().build(); | ||
| } | ||
|
|
||
| // Search for the specific item by ID | ||
| Set<MediaItem> items = library.search(SearchCriteria.builder().id(id.toString()).build()); | ||
| MediaItem item = items.stream().findFirst().orElse(null); | ||
|
|
||
| if (item == null) { | ||
| return ResponseEntity.notFound().build(); | ||
| } | ||
|
|
||
| MediaItemResponse response = MediaItemResponse.from(item); | ||
| return ResponseEntity.ok(response); | ||
| } | ||
|
|
||
| @DeleteMapping("/items/{id}") | ||
| public ResponseEntity<Void> deleteItem(@PathVariable UUID id) { | ||
| try { | ||
| if (!library.hasMediaItem(id)) { | ||
| return ResponseEntity.notFound().build(); | ||
| } | ||
|
|
||
| library.removeMediaItem(id, librarian); | ||
| return ResponseEntity.noContent().build(); | ||
| } catch (MediaItemCheckedOutException e) { | ||
| // Item is checked out and cannot be deleted | ||
| return ResponseEntity.status(HttpStatus.CONFLICT).build(); | ||
| } catch (Exception e) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't need this exception handler. |
||
| return ResponseEntity.internalServerError().build(); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must not change this.