Skip to content

Conversation

@ellankz
Copy link
Contributor

@ellankz ellankz commented Jul 21, 2025

No description provided.

@ellankz ellankz requested a review from Copilot July 21, 2025 10:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the return types of two protected methods in the Document class to support asynchronous operations by changing from Optional<Date> to MaybePromise<Optional<Date>>. This is a non-breaking change that allows these methods to optionally return promises while maintaining backward compatibility.

  • Updated getDisplayDate() and getPublicationDate() method signatures to support both synchronous and asynchronous operations
  • Incremented package version from 4.43.1 to 4.43.2
  • Added changelog entry documenting the MaybePromise enhancement

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/mapper/doc.ts Updated return types for getDisplayDate() and getPublicationDate() methods to support MaybePromise
package.json Version bump to 4.43.2
CHANGELOG.md Added entry for version 4.43.2 documenting the MaybePromise changes

@ellankz ellankz merged commit d1ec22c into main Jul 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants