[pull] master from supabase:master #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where App Router pages (docs, www/blog) only tracked the initial page load but not subsequent navigations. The issue was introduced in PR #35384 which inverted the logic for App Router telemetry tracking. The condition used a boolean flag that prevented tracking after the initial page view. The root cause: useEffect with [appPathname] dependency fires both on initial mount AND on pathname changes. The flag-based approach couldn't differentiate between these two cases. Solution: Track the previous pathname to detect actual changes. - Initial mount: previousAppPathnameRef is null, skip (initial effect handles it) - Navigation: previousAppPathnameRef !== appPathname, send telemetry Before: Only first page view tracked After: All page navigations tracked (like Pages Router) Affects: docs app, www app (blog pages)
* fix table head * fix edge functions list * fix secret * access keys * policies * misc table fixes * publication height fix * fix-publications * table documentation * fix colspan * s3 fixes
* sidebar-manager * storage keys * tests * more ai spots * test fix * revert to default * remove ref * Update apps/studio/state/sidebar-manager-state.tsx Co-authored-by: Copilot <[email protected]> * Update apps/studio/components/ui/AIAssistantPanel/AIAssistant.tsx Co-authored-by: Copilot <[email protected]> * fix ts * fix * fux * fux query param * clean * fix * more * mock local storage * simplify * remove provider test * remve useopensidebar * fix(new homepage): open ai assistant on advisor card button clicks * Update apps/studio/components/layouts/ProjectLayout/LayoutSidebar/index.tsx Co-authored-by: Charis <[email protected]> * Update apps/studio/state/sidebar-manager-state.tsx Co-authored-by: Charis <[email protected]> * refine * editor sidebar manager * reset results * advisor sidebar manager * empty state and notice * event tracking * remove variable * remove use effect * open in sidebar * use sidebar old home * Update apps/studio/components/ui/EditorPanel/EditorPanel.tsx Co-authored-by: Charis <[email protected]> * connect hotkey * Update apps/studio/components/layouts/AppLayout/AssistantButton.tsx Co-authored-by: Charis <[email protected]> * Update apps/studio/state/advisor-state.ts Co-authored-by: Charis <[email protected]> * Update apps/studio/state/advisor-state.ts Co-authored-by: Charis <[email protected]> * fix * initial prompt * fix(inline editor button): only show keyboard shortcut if hotkey active * cleanup(advisor panel): minor code cleanup * fix(advisor panel): misplaced key on list * fix(advisor panel): add error state * fix(advisor panel): improve a11y * fix(advisor panel): cannot find selected item * fix * fix * tooltip * link * sidebar move up * merge inbox * project/org sidebars * panels * clean * fix use effect * layoutheader export * fix * ts * prettier * tests * remove markdown * remove org and project filters from state * text link * Update apps/studio/state/sidebar-manager-state.tsx Co-authored-by: Copilot <[email protected]> * fix * prettier * remove files * bump limit * noop * format * remove notifications on self hosted --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Charis Lam <[email protected]> Co-authored-by: Alaister Young <[email protected]>
* default filters and state fix * add created at * text color * small simplification * always unregister sidebar --------- Co-authored-by: Alaister Young <[email protected]>
…40235) * chore(docs): top nav homepage link toggleable for nimbus * reenable dropdown link by default
…le for nimbus (#40237) chore(docs): top nav (authenticated) homepage link toggleable for nimbus
#40217) * midway * Hook up connect tables e2e * Update isEnabled flag * Change connectingStep to enum * Nit * Nit * Nit * Only show replication status if theres a publication * Improve loading state in etl page * Refactor + Clean up + Add long poll logic when adding more tables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )