Open
Conversation
Signed-off-by: Benjamin Pinchon <dev@mdfr.me>
c7a8e5a to
ca52f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
tag@digestformat in theimage.tagfield, enabling compatibility with dependency update tools like Renovate or Dependabot.Motivation
Renovate and Dependabot can pin container images by digest while preserving the tag for readability. They use the format
tag@digest(e.g., 26.5.3@sha256:abc123...). This provides both:Current chart fails with this format because
image.tagis used in theapp.kubernetes.io/versionlabel:The
@character is invalid in Kubernetes labels, causing deployment to fail:The chart already supports a separate
image.digestfield, but using tag + digest together is mutually exclusive.Changes
Added a
keycloak.imageVersionhelper that extracts the version part (before@) for use in labels. This ensures:@character)