Skip to content

feat: support tag@digest format #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mydoomfr wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −2
Open

feat: support tag@digest format #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion charts/keycloakx/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Common labels
{{- define "keycloak.labels" -}}
helm.sh/chart: {{ include "keycloak.chart" . }}
{{ include "keycloak.selectorLabels" . }}
app.kubernetes.io/version: {{ .Values.image.tag | default .Chart.AppVersion | toString | trunc 63 | quote }}
app.kubernetes.io/version: {{ include "keycloak.imageVersion" . | quote }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{- end }}

Expand Down Expand Up @@ -85,3 +85,34 @@ Renders a complete tree, even values that contains template.
{{- tpl (.value | toYaml) .context }}
{{- end }}
{{- end -}}

{{/*
Extract version from tag, removing digest suffix if present.
Supports formats: "1.2.3", "1.2.3@sha256:abc123"
Returns only the version part (before @) for use in Kubernetes labels.
*/}}
{{- define "keycloak.imageVersion" -}}
{{- $tag := .Values.image.tag | default .Chart.AppVersion | toString -}}
{{- $parts := splitList "@" $tag -}}
{{- first $parts | trunc 63 -}}
{{- end -}}

{{/*
Build the full image reference.
Supports multiple formats:
- tag only: "repository:tag"
- digest only: "repository@digest" (when image.digest is set)
- tag@digest in tag field: "repository:tag@digest"
*/}}
{{- define "keycloak.image" -}}
{{- $repository := .Values.image.repository -}}
{{- $digest := .Values.image.digest | default "" -}}
{{- if $digest -}}
{{- /* Digest field is set - use digest only */ -}}
{{- printf "%s@%s" $repository $digest -}}
{{- else -}}
{{- $tag := .Values.image.tag | default .Chart.AppVersion | toString -}}
{{- /* Tag may contain digest (tag@digest format from Renovate) */ -}}
{{- printf "%s:%s" $repository $tag -}}
{{- end -}}
{{- end -}}
2 changes: 1 addition & 1 deletion charts/keycloakx/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ spec:
- name: keycloak
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}{{- if (.Values.image.digest) -}}@{{ .Values.image.digest }}{{- else -}}:{{ .Values.image.tag | default .Chart.AppVersion }} {{- end }}"
image: {{ include "keycloak.image" . | quote }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- if .Values.command }}
command:
Expand Down