[fix] Only count directly changed lines as misses when intended changes is specified

[rohitvinnakota-codecov]

Closes codecov/engineering-team#3030

We choose segments with indirectly changed lines even if a user queries for intended changes only if they have diff changes. With this PR, we will exclude those lines from each segment.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (15d2415) to head (d9f91e4).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files         828      828           
  Lines       19463    19479   +16     
=======================================
+ Hits        18689    18705   +16     
  Misses        774      774           

Flag	Coverage Δ
unit	92.31% <100.00%> (+<0.01%)	⬆️
unit-latest-uploader	92.31% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-notifications]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[codecov-qa]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
2666	1	2665	6

View the top 1 failed tests by shortest run time

services/tests/test_comparison.py::ComparisonReportTest::test_remove_unintended_changes

Stack Traces | 0.049s run time

self = <services.tests.test_comparison.ComparisonReportTest testMethod=test_remove_unintended_changes>

    def test_remove_unintended_changes(self):
        lines = [
            LineComparison(1, 1, 1, 1, "line1", False),
            LineComparison(1, 0, 2, 2, "line2", False),
            LineComparison(0, 0, None, 3, "+line3", True),
            LineComparison(0, 0, 4, None, "-line4", True),
            LineComparison(1, 0, 5, 5, "line5", False),
        ]
    
        segment = Segment(lines)
>       segment.remove_unintended_changes()

services/tests/test_comparison.py:1798: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
services/comparison.py:487: in remove_unintended_changes
    base_cov = line.coverage["base"]
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <services.comparison.LineComparison object at 0x7fac78badc40>

    @property
    def coverage(self):
        return {
            "base": None
            if self.added or not self.base_line
>           else line_type(self.base_line[0]),
            "head": None
            if self.removed or not self.head_line
            else line_type(self.head_line[0]),
        }
E       TypeError: 'int' object is not subscriptable

services/comparison.py:337: TypeError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

[codecov-public-qa]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
2666	1	2665	6

View the top 1 failed tests by shortest run time

services/tests/test_comparison.py::ComparisonReportTest::test_remove_unintended_changes

Stack Traces | 0.049s run time

self = <services.tests.test_comparison.ComparisonReportTest testMethod=test_remove_unintended_changes>

    def test_remove_unintended_changes(self):
        lines = [
            LineComparison(1, 1, 1, 1, "line1", False),
            LineComparison(1, 0, 2, 2, "line2", False),
            LineComparison(0, 0, None, 3, "+line3", True),
            LineComparison(0, 0, 4, None, "-line4", True),
            LineComparison(1, 0, 5, 5, "line5", False),
        ]
    
        segment = Segment(lines)
>       segment.remove_unintended_changes()

services/tests/test_comparison.py:1798: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
services/comparison.py:487: in remove_unintended_changes
    base_cov = line.coverage["base"]
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <services.comparison.LineComparison object at 0x7fac78badc40>

    @property
    def coverage(self):
        return {
            "base": None
            if self.added or not self.base_line
>           else line_type(self.base_line[0]),
            "head": None
            if self.removed or not self.head_line
            else line_type(self.head_line[0]),
        }
E       TypeError: 'int' object is not subscriptable

services/comparison.py:337: TypeError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

[github-actions]

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[spalmurray-codecov]

This logic says if line is in the diff or coverage on the line has not changed, then it's unintended (coverage change on non-diff line) and we should filter it out. Correct?

[rohitvinnakota-codecov]

Correct yep

[spalmurray-codecov]

Looks good. Just want to confirm that these indirect changes will still show in the indirect changes tab?

[rohitvinnakota-codecov]

yep

[spalmurray-codecov]

Solid lgtm