This repository was archived by the owner on Jun 13, 2025. It is now read-only.
fix(ta-gql): get testsuites #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: graphql_api/types/test_analytics/test_analytics.py
Did you find this useful? React with a 👍 or 👎 |
Contributor
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
+ Coverage 96.29% 96.43% +0.13%
==========================================
Files 488 488
Lines 16976 16995 +19
==========================================
+ Hits 16347 16389 +42
+ Misses 629 606 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
I made a change previously that made it so the testsuite column in the dataframe returned by get_results became a list[str] instead of str but I didn't update get testsuites to reflect that. This fixes that. also adds a test for the new V1 format that also verifies it populates the testsuites correctly and fixes a bug with that format renaming a column
it's possible for the avg_duration to be NaN (which is fine) but I wasn't taking this into account in the aggregate calculation which meant that the NaN's were propagating to the total duration and slowest tests duration so we need to replace them with 0 because that's effectively what they are
joseph-sentry
force-pushed
the
joseph/testsuite
branch
from
878b22a to
0194300
Compare
nora-shap
approved these changes
Apr 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a change previously that made it so the testsuite column in the dataframe returned by get_results became a list[str] instead of str but I didn't update get testsuites to reflect that. This fixes that.
also adds a test for the new V1 format that also verifies it populates the testsuites correctly and fixes a bug with that format renaming a column