Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Nov 6, 2024

This PR adds a upload-coverage command to use a new combined upload approach that consolidates the create commit, create report, and upload steps into a single network call when possible. This optimization reduces network overhead by combining what were previously three separate API calls into one.

  • Added new upload_coverage function that handles all three steps (create commit, create report, and upload) in one operation. This will be called with the upload-coverage command.

upload-process still behaves the same as previously.

Depends on codecov/codecov-api#962

Closes codecov/engineering-team#2538

@github-actions
Copy link

github-actions bot commented Nov 6, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov
Copy link

codecov bot commented Nov 7, 2024

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3550 5 3545 0
View the top 3 failed tests by shortest run time
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@ghost ghost marked this pull request as ready for review November 8, 2024 18:42
@ghost ghost changed the title Single endpoint coverage command initial implementation Upload-process uses combined-upload endpoint Nov 8, 2024
@ghost ghost self-requested a review November 8, 2024 18:54
Swatinem
Swatinem previously approved these changes Nov 11, 2024
@ghost ghost requested a review from Swatinem November 12, 2024 08:25
Swatinem
Swatinem previously approved these changes Nov 12, 2024
@ghost ghost changed the title Upload-process uses combined-upload endpoint Upload-process uses upload-coverage endpoint Nov 18, 2024
@ghost ghost requested a review from Swatinem November 18, 2024 09:44
@ghost ghost removed the request for review from Swatinem November 18, 2024 09:45
@ghost ghost marked this pull request as draft November 18, 2024 09:47
Adding upload-coverage as a separate command
@ghost ghost marked this pull request as ready for review November 18, 2024 13:56
@ghost ghost requested a review from Swatinem November 18, 2024 14:10
Swatinem
Swatinem previously approved these changes Nov 18, 2024
@ghost ghost requested a review from Swatinem November 18, 2024 15:08
@ghost ghost requested review from Swatinem and thomasrockhu-codecov and removed request for Swatinem November 25, 2024 11:32
@ghost ghost removed the request for review from thomasrockhu-codecov November 25, 2024 16:02
@ghost ghost merged commit 1f04560 into main Nov 25, 2024
19 of 21 checks passed
@ghost ghost deleted the tony/single-endpoint-coverage-command branch November 25, 2024 19:51
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI] Move upload-process command to use single upload endpoint

2 participants