Skip to content

Relax dir assertion with a new ConfigGetDirResponseAssertion#233

Merged
andy1li merged 2 commits intomainfrom
andy/add-config-get-dir-response-assertion
Dec 15, 2025
Merged

Relax dir assertion with a new ConfigGetDirResponseAssertion#233
andy1li merged 2 commits intomainfrom
andy/add-config-get-dir-response-assertion

Conversation

@andy1li
Copy link
Member

@andy1li andy1li commented Dec 15, 2025

Note

Introduce a CONFIG GET dir response assertion that tolerates an optional trailing slash and update the RDB config test to use it.

  • Assertions:
    • Add ConfigGetDirResponseAssertion to validate CONFIG GET dir responses, accepting "dir" key and directory value with optional trailing slash.
  • Tests:
    • Update internal/test_rdb_config.go to use NewConfigGetDirResponseAssertion(tmpDir) instead of ordered bulk string array assertion.

Written by Cursor Bugbot for commit 93ff6bb. This will update automatically on new commits. Configure here.

@andy1li andy1li self-assigned this Dec 15, 2025
@andy1li
Copy link
Member Author

andy1li commented Dec 15, 2025

Thanks to @OlaoluwaM for highlighting the issue!

@andy1li andy1li force-pushed the andy/add-config-get-dir-response-assertion branch from cf8db3e to 93ff6bb Compare December 15, 2025 02:50
@andy1li andy1li requested a review from rohitpaulk December 15, 2025 03:29
@andy1li andy1li merged commit b561aca into main Dec 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants