-
Couldn't load subscription status.
- Fork 22
Add a message informing the user about benchmark progress #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
| if self.args.benchmark and num_optimizable_functions > 0: | ||
| with progress_bar(f"Running benchmarks in {self.args.benchmarks_root}", transient=True): | ||
| with progress_bar(f"Running benchmarks in {self.args.benchmarks_root}",transient=True): | ||
| logger.info(f"Running benchmarks in {self.args.benchmarks_root}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a case where the above message prints in interactive console mode but doesn't in non-interactice consoles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am closing this issue as this can be solved in Pycharm by selecting 'Emulate terminal in output console' in the run configuration
|
|
|
I am closing this issue as this can be solved in Pycharm by selecting 'Emulate terminal in output console' in the run configuration |
PR Type
Enhancement
Description
Simplify progress_bar call invocation
Move benchmark start message to logger.info
Changes walkthrough 📝
optimizer.py
Simplify progress_bar and add log messagecodeflash/optimization/optimizer.py
logger.infofor benchmark start