Skip to content

Add a message informing the user about benchmark progress #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add a message informing the user about benchmark progress #247

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e26fba
quick fix
aseembits93 May 28, 2025
37cff02
quick fix
aseembits93 May 28, 2025
5e341d0
precommit fix
aseembits93 May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion codeflash/optimization/optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ def run(self) -> None:
function_benchmark_timings: dict[str, dict[BenchmarkKey, int]] = {}
total_benchmark_timings: dict[BenchmarkKey, int] = {}
if self.args.benchmark and num_optimizable_functions > 0:
with progress_bar(f"Running benchmarks in {self.args.benchmarks_root}", transient=True):
with progress_bar(f"Running benchmarks in {self.args.benchmarks_root}",transient=True):
logger.info(f"Running benchmarks in {self.args.benchmarks_root}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a case where the above message prints in interactive console mode but doesn't in non-interactice consoles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am closing this issue as this can be solved in Pycharm by selecting 'Emulate terminal in output console' in the run configuration

# Insert decorator
file_path_to_source_code = defaultdict(str)
for file in file_to_funcs_to_optimize:
Expand Down
Loading