[LSP] Create function optimizer during the optimization initialization step & remove optimization metadata logic

[mohammedahmed18]

Initialized the function optimizer during the initialization step mainly to get the original content of the helpers as they are stored in the extension to act as a common ancestor for performing a 3-way merge later in the extension,

also it makes more sense

PR Type

Enhancement

---

Description

• Remove patch metadata JSON handling

• Initialize function optimizer during init step

• Return repo root in project init

• Simplify patch creation API and usage

---

Diagram Walkthrough

flowchart LR
  LSP["LSP initProject"] -- "adds repo root" --> Client["Client"]
  InitFO["initializeFunctionOptimization"] -- "prepare module + create FunctionOptimizer" --> Store["store init result"]
  PerformFO["performFunctionOptimization"] -- "use stored init result" --> Optimize["run optimization"]
  Optimize -- "diff from worktree" --> Patch["create .patch file (no metadata)"]

Loading

File Walkthrough

Relevant files

Enhancement

git_worktree_utils.py Simplify patch creation; remove metadata handling                codeflash/code_utils/git_worktree_utils.py Remove JSON metadata and file locks Simplify patch creation function signature Return Path or None instead of metadata dict Drop metadata fields construction +5/-56    beta.py Rework LSP optimization flow and responses                              codeflash/lsp/beta.py Add init params and separate optimization init step Create FunctionOptimizer during init; cache init result Remove metadata retrieval/deletion endpoints Include repo root in init_project responses Use simplified patch creation; return task_id +91/-123 server.py Store and reset optimization init state                                    codeflash/lsp/server.py Track current optimization init result on server Reset cached init result during cleanup +3/-0      optimizer.py Adapt optimizer to new patch API                                                  codeflash/optimization/optimizer.py Use simplified patch creation API Store returned patch path directly Remove obsolete metadata usage +2/-3

---

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Issue When no changes are found, the function now returns None instead of an empty dict. Call sites should handle None to avoid TypeErrors or invalid response payloads. worktree_dir: Path, files: list[str], fto_name: Optional[str] = None ) -> Optional[Path]: repository = git.Repo(worktree_dir, search_parent_directories=True) uni_diff_text = repository.git.diff(None, "HEAD", *files, ignore_blank_lines=True, ignore_space_at_eol=True) if not uni_diff_text: logger.warning("No changes found in worktree.") return None Return Type Consistency The LSP handler now returns the Path object directly in the response ('patch_file': patch_path). Ensure serialization to string before sending over LSP to avoid JSON serialization issues. server.show_message_log(f"Optimization completed for {params.functionName} with {speedup:.2f}x speedup", "Info") return { "functionName": params.functionName, "status": "success", "message": "Optimization completed successfully", "extra": f"Speedup: {speedup:.2f}x faster", "patch_file": patch_path, "task_id": params.task_id, "explanation": best_optimization.explanation_v2, } None Handling create_diff_patch_from_worktree may return None; code appends patch_path to self.patch_files without checking, potentially inserting None and causing downstream errors. optimizations_found += 1 # create a diff patch for successful optimization if self.current_worktree: best_opt = best_optimization.unwrap() read_writable_code = best_opt.code_context.read_writable_code relative_file_paths = [ code_string.file_path for code_string in read_writable_code.code_strings ] patch_path = create_diff_patch_from_worktree( self.current_worktree, relative_file_paths, fto_name=function_to_optimize.qualified_name, ) self.patch_files.append(patch_path) if i < len(functions_to_optimize) - 1: create_worktree_snapshot_commit( self.current_worktree, f"Optimizing {functions_to_optimize[i + 1].qualified_name}",

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Check for missing patch file Handle the case where no diff is produced and create_diff_patch_from_worktree returns None to prevent returning a None path or crashing downstream. Return an error or adjust the success payload accordingly. codeflash/lsp/beta.py [430-444] patch_path = create_diff_patch_from_worktree( server.optimizer.current_worktree, relative_file_paths, function_to_optimize_qualified_name ) -... +if patch_path is None: + return { + "functionName": params.functionName, + "status": "error", + "message": "No changes detected; patch not created", + "task_id": params.task_id, + } return { "functionName": params.functionName, "status": "success", "message": "Optimization completed successfully", "extra": f"Speedup: {speedup:.2f}x faster", - "patch_file": patch_path, + "patch_file": str(patch_path), "task_id": params.task_id, "explanation": best_optimization.explanation_v2, } Suggestion importance[1-10]: 8 __ Why: create_diff_patch_from_worktree now returns None when no changes exist; handling this avoids returning a None path and improves error signaling. It directly aligns with the PR change and prevents runtime issues.	Medium
	Guard against None patch paths Avoid appending None when no diff is generated; check the returned value before storing it. This prevents None entries and potential errors when consuming self.patch_files. codeflash/optimization/optimizer.py [352-358] patch_path = create_diff_patch_from_worktree( self.current_worktree, relative_file_paths, fto_name=function_to_optimize.qualified_name, ) -self.patch_files.append(patch_path) +if patch_path is not None: + self.patch_files.append(str(patch_path)) Suggestion importance[1-10]: 8 __ Why: Since the helper can return None, appending only when a path exists prevents None entries and downstream errors. This is correct and important for maintaining valid state.	Medium
	Sanitize patch filename Guard against fto_name being None or containing filesystem-unsafe characters to avoid invalid filenames or overwriting unintended files. Normalize the name and provide a safe fallback. codeflash/code_utils/git_worktree_utils.py [115-118] -patch_path = project_patches_dir / f"{worktree_dir.name}.{fto_name}.patch" +safe_name = (fto_name or "unknown").replace("/", "_").replace("\\", "_").replace(" ", "_") +patch_path = project_patches_dir / f"{worktree_dir.name}.{safe_name}.patch" with patch_path.open("w", encoding="utf8") as f: f.write(uni_diff_text) Suggestion importance[1-10]: 7 __ Why: fto_name can be None and may contain unsafe characters; sanitizing prevents invalid filenames and is consistent with the new return type. The change is accurate and low-risk, improving robustness.	Medium