Skip to content

fix: align reconciler requeue and error handling logic, add failure and warning error properties #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+42 −2
Draft

fix: align reconciler requeue and error handling logic, add failure and warning error properties #780

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92f9a73
update crd for warnings and failure props
scme0 Oct 3, 2025
5c7df45
update promotion task crd
scme0 Oct 3, 2025
7eb8476
update promotion task crd
scme0 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions charts/gitops-runtime/templates/_components/gitops-operator/crds/promotiontasks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,22 @@ spec:
createdAt:
format: date-time
type: string
failure:
properties:
code:
type: string
message:
type: string
stepIndex:
type: integer
while:
type: string
required:
- code
- message
- stepIndex
- while
type: object
observedGeneration:
format: int64
type: integer
Expand All @@ -399,8 +415,6 @@ spec:
items:
description: StepStatus
properties:
failureSummary:
type: string
getPromotionValues:
properties:
commitAuthorAvatarUrl:
Expand Down Expand Up @@ -633,6 +647,32 @@ spec:
updatedAt:
format: date-time
type: string
warnings:
items:
properties:
count:
type: integer
error:
properties:
code:
type: string
message:
type: string
stepIndex:
type: integer
while:
type: string
required:
- code
- message
- stepIndex
- while
type: object
required:
- count
- error
type: object
type: array
required:
- createdAt
- phase
Expand Down