Skip to content

Conversation

@grimpirate
Copy link
Contributor

Description
While making changes to #9928 noticed there were two variables prior to the return statement which add horizontal space padding around $max_lifetime. These statements are unnecessary and do not enhance code readability.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch. However, please remove unnecessary white spaces.

I think we supported both drivers here in the past, but since PostgreSQL now has its own version, this method can be simplified.

@michalsn michalsn changed the title refactor: Removal of unneeded code refactor: cleanup DatabaseHandler::gc() for session Oct 21, 2024
@michalsn michalsn merged commit 11d9721 into codeigniter4:develop Oct 22, 2024
41 checks passed
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants