Skip to content

refactor: cleanup DatabaseHandler::gc() for session #9230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2024
Merged

refactor: cleanup DatabaseHandler::gc() for session #9230

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
103cc9e
Removal of unneeded operations/variables
grimpirate Oct 18, 2024
683922f
Update system/Session/Handlers/DatabaseHandler.php
michalsn Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions system/Session/Handlers/DatabaseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,9 @@ public function destroy($id): bool
#[ReturnTypeWillChange]
public function gc($max_lifetime)
{
$separator = ' ';
$interval = implode($separator, ['', "{$max_lifetime} second", '']);

return $this->db->table($this->table)->where(
'timestamp <',
"now() - INTERVAL {$interval}",
"now() - INTERVAL {$max_lifetime} second ",
false
)->delete() ? 1 : $this->fail();
}
Expand Down
Loading