fix: getVersion() for OCI8 and SQLSRV drivers
#9471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
added
the
bug
samsonasik
reviewed
Feb 28, 2025
|
|
||
| public function testGetVersion(): void | ||
| { | ||
| if ($this->db->DBDriver === 'MySQLi') { |
There was a problem hiding this comment.
This should can use if ($this->db instanceof \CodeIgniter\Database\MySQLi\Connection)
There was a problem hiding this comment.
Yes, but since this type of comparison is widely used in our tests, I personally find it more readable. However, if others prefer the change, I'm happy to update it.
There was a problem hiding this comment.
The benefit of instanceof is phpstan will be fixed for no property notice
michalsn
changed the title
getVersion() for OCI8 driver when no connection is establishedgetVersion() for OCI8 and SQLSRV drivers
paulbalandan
approved these changes
Mar 4, 2025
michalsn
force-pushed
the
fix/oci8-getVersion
branch
from
fd01f33 to
f4d8a02
Compare
|
Thank you everyone for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in OCI8 and SQLSRV
getVersion()method, which will return an empty string when no connection is established.Issue discovered in #9469
Checklist: