Skip to content

fix: ensure make:test works on Windows #9635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulbalandan merged 2 commits into from
Jul 15, 2025
Merged

fix: ensure make:test works on Windows #9635

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
321075d
fix: ensure `make:test` works on Windows
paulbalandan Jul 14, 2025
1e0f865
Add changelog
paulbalandan Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions system/Commands/Generators/TestGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,20 +173,17 @@ protected function buildPath(string $class): string
/**
* Returns test file path for the namespace.
*/
private function searchTestFilePath(string $namespace): ?string
private function searchTestFilePath(string $testNamespace): ?string
{
$bases = service('autoloader')->getNamespace($namespace);
/** @var list<non-empty-string> $testPaths */
$testPaths = service('autoloader')->getNamespace($testNamespace);

$base = null;

foreach ($bases as $candidate) {
if (str_contains($candidate, '/tests/')) {
$base = $candidate;

break;
foreach ($testPaths as $candidate) {
if (str_contains($candidate, DIRECTORY_SEPARATOR . 'tests' . DIRECTORY_SEPARATOR)) {
return $candidate;
}
}

return $base;
return null;
}
}
Loading