Annotate PMD fixes with inline comments

[shai-almog]

Summary

• add inline comments beside each prior PMD remediation explaining the specific warning resolved
• ensure loop, modifier, and wrapper adjustments in UI, chart, and cloud utilities reference their PMD rationale directly in code comments

Testing

• not run

---

https://chatgpt.com/codex/tasks/task_e_68f2318a18b0833187e7e427a6746132

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 41 total, 0 failed, 0 skipped
• 📊 Line coverage: 2.95% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.services.RSSService$1 – 0.00%
    • com.codename1.io.services.ImageDownloadService – 0.00%
    • com.codename1.io.services.ImageDownloadService$6 – 0.00%
    • com.codename1.io.services.ImageDownloadService$1 – 0.00%
    • com.codename1.io.services.ImageDownloadService$3 – 0.00%
    • com.codename1.io.services.ImageDownloadService$2 – 0.00%
    • com.codename1.io.services.ImageDownloadService$5 – 0.00%
    • com.codename1.io.services.ImageDownloadService$4 – 0.00%
    • com.codename1.io.services.TwitterRESTService$1 – 0.00%
    • com.codename1.io.services.RSSService$1FinishParsing – 0.00%

Static Analysis

• ❌ SpotBugs: 2466 findings (High: 121, Normal: 1422, Low: 923) [HTML preview] [Download]
  • Top findings
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:39 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:31 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:34 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/views/XYChart.java:132 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
    • High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:49 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
    • …and 2461 more
• ❌ PMD: 3924 findings (P2: 1, P3: 1604, P4: 2319) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/ui/geom/GeneralPath.java:2886 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
    • P3: CodenameOne/src/com/codename1/components/ScaleImageLabel.java:248 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/components/ScaleImageLabel.java:264 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/components/SliderBridge.java:95 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/components/SplitPane.java:579 – Avoid unused private methods such as 'setDividerInset(String)'. (rule: UnusedPrivateMethod)
    • …and 3919 more
• ❌ Checkstyle: 232558 findings (Warning: 232558) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:31 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:35 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:38:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:41 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • …and 232553 more

Generated automatically by the PR CI workflow.

[shai-almog]

✅ Native Android screenshot tests passed.