-
Notifications
You must be signed in to change notification settings - Fork 433
Fixed CI to avoid dynamic classloading #4152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also used callSerially to avoid blocking the start method on Android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try { | ||
| testClass.prepare(); | ||
| testClass.runTest(); | ||
| testClass.cleanup(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runSuite now calls testClass.prepare(); testClass.runTest(); testClass.cleanup(); directly and never checks the boolean returned by runTest() or notifies TestReporting about start/finish. If any test returns false (e.g., MediaPlaybackScreenshotTest when media creation fails), the suite logs it as “finished” and still emits CN1SS:SUITE:FINISHED, so CI and Cn1ssDeviceRunnerReporter will never mark the test as failed. Please capture the return value and call startingTestCase/finishedTestCase so failed tests are surfaced.
Useful? React with 👍 / 👎.
| log("CN1SS:INFO:suite starting test=" + testClass); | ||
| try { | ||
| testClass.prepare(); | ||
| testClass.runTest(); | ||
| testClass.cleanup(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suite now executes each AbstractTest inline on the EDT (HelloCodenameOne.start schedules runSuite via CN.callSerially) without the DeviceRunner.runTest threading logic that honored shouldExecuteOnEDT(). With the default false, tests such as BrowserComponentScreenshotTest and MediaPlaybackScreenshotTest call Cn1ssDeviceRunnerHelper.waitForMillis() (uses Util.sleep) and rely on the EDT to process onLoad/media callbacks; running them on the EDT freezes the event loop so those callbacks never fire and the suite hangs/fails. Restore the off-EDT execution or thread-switching before invoking each test.
Useful? React with 👍 / 👎.
Android screenshot updatesCompared 4 screenshots: 1 matched, 1 updated, 2 missing references.
Native Android coverage
|
9acb8c8 to
617b329
Compare
13b0841 to
83baaea
Compare
58ad188 to
e17ec30
Compare
1d5e511 to
951062e
Compare









Also used callSerially to avoid blocking the start method on Android