-
Notifications
You must be signed in to change notification settings - Fork 433
Fix flaky BrowserComponentScreenshotTest race condition and timing #4276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky BrowserComponentScreenshotTest race condition and timing #4276
Conversation
Addressed race condition where onLoad might fire before the test callback is registered. Increased post-load delay to 500ms to allow rendering to complete on slower devices. Modified test to instantiate BrowserComponent and add listeners before navigation starts.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Android screenshot updatesCompared 30 screenshots: 0 matched, 3 updated, 27 missing references.
Native Android coverage
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |




























































This PR fixes the flakiness observed in
BrowserComponentScreenshotTeston iOS and potential hangs on JavaSE.The previous implementation registered the
onLoadlistener inside theonShowCompletedcallback. If the browser loaded the content (which is a simple string) beforeonShowCompletedfired, theonLoadevent would be missed, causing the test to hang until timeout.The new implementation:
BrowserComponentand adds theonLoadlistener immediately inrunTest, setting aloadedflag.onLoadfires and whenregisterReadyCallbackis called.BrowserComponentis fully rendered (addressing the blank/white screenshot issue on iOS).PR created automatically by Jules for task 11718286186027719055 started by @shai-almog